Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time based warning is not specific enough to identify source. #36

Closed
rwjblue opened this issue Nov 4, 2016 · 2 comments
Closed

Time based warning is not specific enough to identify source. #36

rwjblue opened this issue Nov 4, 2016 · 2 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Nov 4, 2016

This warning does not give enough context to know what is actually causing the output.

Seeing the following lines in my CI logs (surrounded by a thousand lines of other things) doesn't provide enough context:

[WARN] `assets/web-client.js` took: 30636ms (more than 20,000ms)
[WARN] `assets/web-client.js` took: 22009ms (more than 20,000ms)

I suggest that we update the warning to at least say something like:

[WARN] (broccoli-uglify-sourcemap) Minifying assets/web-client.js took: XXXXXms

Thoughts?
@ef4
Copy link
Collaborator

ef4 commented Nov 4, 2016

Seems good to me.

stefanpenner added a commit that referenced this issue Dec 20, 2016
@stefanpenner
[Fixes #38 #36] improve slow concat warning
ea4e953 
* don’t show of `—silent` is used
* identify the current plugin when warning
stefanpenner added a commit that referenced this issue Dec 20, 2016
@stefanpenner
[Fixes #38 #36] improve slow concat warning
587dba4 
* don’t show of `—silent` is used
* identify the current plugin when warning
stefanpenner added a commit that referenced this issue Dec 20, 2016
@stefanpenner
Merge pull request #39 from ef4/fixes
d9de319 
[Fixes #38 #36] improve slow concat warning
@Zooman090
Copy link

I have same problems, but with
[WARN] (broccoli-uglify-sourcemap) Minifying: assets/vendor.js took: 33105ms (more than 20,000ms)

@balos1 balos1 mentioned this issue Jul 12, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stefanpenner @rwjblue @ef4 @Zooman090