Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to access length of minified code if minification failed #59

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Do not try to access length of minified code if minification failed #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ UglifyWriter.prototype.processFile = function(inFile, outFile, relativePath, out
var result = UglifyJS.minify(src, options);
var end = new Date();
var total = end - start;
debug('[finished]: %s %dKB in %dms', relativePath, (result.code.length / 1000), total);

if (total > 20000 && !silent) {
console.warn('[WARN] (broccoli-uglify-sourcemap) Minifying: `' + relativePath + '` took: ' + total + 'ms (more than 20,000ms)');
}
Expand All @@ -127,6 +125,8 @@ UglifyWriter.prototype.processFile = function(inFile, outFile, relativePath, out
throw result.error;
}

debug('[finished]: %s %dKB in %dms', relativePath, (result.code.length / 1000), total);

if (options.sourceMap) {
var newSourceMap = JSON.parse(result.map);

Expand Down