Do not try to access length
of minified code if minification failed
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
UglifyJS.minify(src, options)
(line 116) fails, theresult
object will have the following form:In this case, attempting to access
result.code.length
causes broccoli to fail withCannot read property 'length' of undefined
, and the error report file shows only the stack trace for this error, not the actual minification error.Moving the
debug
line below thethrow
ensures that the user sees the real cause of the error (the uglifyjs stack trace) in the console and error report file.Happy to add example or test if necessary - discovered during a long broccoli debugging session...