Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

fix multiple calls to the options method when using the ajax-support mixin #146

Merged
merged 1 commit into from
Sep 8, 2016
Merged

fix multiple calls to the options method when using the ajax-support mixin #146

merged 1 commit into from
Sep 8, 2016

Conversation

kketch
Copy link
Contributor

@kketch kketch commented Aug 19, 2016

The ajax-support mixin currently calls ember-data adapter's ajaxOptions method which is overriden by the same mixin and calls the options method. But the options method is then again called by the ajaxService, as a result it is called twice.

To fix this ajaxOptions is not overriden anymore in the ajax-support mixin, and is
not called anymore by the ajax method, as it should not be needed by ember-ajax I think
and is a private method of the ember-data adapter.

@kketch kketch changed the title fix multiple calls to the options method of the ajax service fix multiple calls to the options method when using the ajax-support mixin Aug 19, 2016
ajaxOptions is not overriden anymore in the ajax-support mixin, and is
not called anymore by the ajax method, as it is not needed by ember-ajax
and is a private method of the ember-data adapter
@alexlafroscia
Copy link
Collaborator

Hey, thanks for submitting this. I think this makes a lot of sense, since ajaxOptions doesn't actually get called anywhere other than the ajax method we're overwriting anyway!

@alexlafroscia alexlafroscia merged commit c68bdf5 into ember-cli:master Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants