Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

fix: avoid TypeScript files in app directory #429

Merged
merged 1 commit into from
Mar 3, 2019
Merged

fix: avoid TypeScript files in app directory #429

merged 1 commit into from
Mar 3, 2019

Conversation

alexlafroscia
Copy link
Collaborator

Fixes #428

Turbo87
Turbo87 approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like CI is failing due to #431, which should be fixed by #433

the change here seems reasonable though and ember-cli-typescript@2 will actually only allow JS files in the app folder anyway 👍

@Turbo87 Turbo87 force-pushed the fix-ts-in-app-tree branch from 67610ae to f85433c Compare March 3, 2019 11:23
@Turbo87 Turbo87 merged commit 44ba175 into master Mar 3, 2019
@Turbo87 Turbo87 deleted the fix-ts-in-app-tree branch March 3, 2019 11:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlafroscia @Turbo87