Run test suite on TravisCI and fix Node 4 compatibility #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
changed the title
|
All seems fine, but I’m not sure why you did these last few PR’s instead of just merging mine which did all of these things (declare node engine, setup CI, add linting, fix node 4 issues, etc)...
|
|
there are several things in this PR that yours did not yet do. initially I thought I could enable CI here and then fix the Node 4 issues in your PR, but it's late here and I only later realize that that would not work as I had imagined 🙈 |
|
Hehe, all good. Just sorry you had to do the extra work. 😃
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently that has never happened before for this repo 😱