Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved deprecation warnings #129

Merged
merged 6 commits into from
Jul 5, 2017
Merged

Improved deprecation warnings #129

merged 6 commits into from
Jul 5, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jul 4, 2017

bildschirmfoto 2017-07-04 um 10 22 06

Resolves #128

@Turbo87 Turbo87 requested a review from rwjblue July 4, 2017 08:25
rwjblue
rwjblue reviewed Jul 4, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the message to include the offending module name (e.g. the module that is using the old shims)?

@Turbo87
Copy link
Member Author

Turbo87 commented Jul 4, 2017

I don't know... how can I access that?

@Turbo87 Turbo87 mentioned this pull request Jul 5, 2017
Merged
@Turbo87
Copy link
Member Author

Turbo87 commented Jul 5, 2017

@rwjblue I don't think this is currently possible (see ember-cli/loader.js#126 (comment))

@Turbo87 Turbo87 merged commit cea962d into ember-cli:master Jul 5, 2017
@Turbo87 Turbo87 deleted the improved-deprecation branch July 5, 2017 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @rwjblue