Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Output TypeScript apps and addons for StackBlitz #10198

Merged

Conversation

NullVoxPopuli
Copy link
Contributor

Prompted from https://twitter.com/ericsimons40/status/1629601959148748806

the JS template is already generated from this script and is viewable here:
https://stackblitz.com/github/ember-cli/editor-output/tree/stackblitz-app-output

Once this PR is merged, we will then have both:

Once this PR is merged (and I suppose another version of ember-cli released? (so that the dev script runs)),
@EricSimons has said that they'll get the two links (above, for JS and TS), added to the Stackblitz site so that Ember shows up here in the frontend category: https://stackblitz.com/?starters=frontend

image

@bertdeblock
Copy link
Member

Seems okay to me. The use of the --typescript option will slow down the after:release script.
Ping @kellyselden to see if that's okay for you.

@kellyselden
Copy link
Member

Seems good to me.

@bertdeblock bertdeblock changed the title Also output --typescript output for Stackblitz [INTERNAL] Output TypeScript apps and addons for StackBlitz Feb 28, 2023
@bertdeblock bertdeblock merged commit bcea391 into ember-cli:master Feb 28, 2023
@bertdeblock
Copy link
Member

Thank you @NullVoxPopuli.

@NullVoxPopuli NullVoxPopuli deleted the typescript-editor-outputs branch February 28, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants