-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Addon-import support for built-in blueprints #3690
Conversation
17e136f
to
a2a701e
Compare
Added some tests for generating inside an addon, and added a silent error for generating addons that don't contain a |
a2a701e
to
a898e37
Compare
@rwjblue @stefanpenner this is ready for review. I wasn't quite sure which blueprints we should generate in this manner, but right now I've got route and resource throwing a warning, since they error anyway trying to modify I cleaned up the tests a bit, creating addon and in-repo-addon destroy and generate tests, and I moved the already existing ones out of the generate and destroy tests. |
a898e37
to
a18d9c0
Compare
LVGTM, but i will want to do a more thorough review and test it out in the AM (getting a bit sleepy) |
[ENHANCEMENT] Addon-import support for built-in blueprints
PERFECT THANK YOU!!! |
@trabus I needed this so much last week, however I am sure I will need it again and again 👍 thanks. |
Use shorthand ES6 re-export for addon-imports as well, which landed in #3690
This PR changes the way blueprints are generated inside addons, following the recommendation here of importing the actual addon code into the app with a wrapper, like so:
I copied the
component-addon
blueprint with a general purposeaddon-import
blueprint that will allow it to be used for all blueprints that need it.I still need to create generate and destroy tests for all the blueprints that had support added, and will do so this evening. I also need to make sure that the blueprints that shouldn't generate the import (anything that doesn't have a
__root__
token and isn't a mixin) aren't doing so, or causing any other side effects. Mostly wanted to put it up for review.