[BUGFIX] Add yuidocs for the addon:init method #6910
Conversation
mattmarcum
changed the title
| @public | ||
| @method init | ||
| @param {Project|Addon} parent The project or addon that directly depends on this addon | ||
| @param {Project} project The current project (deprecated) |
There was a problem hiding this comment.
could you add an @example for this method? I think the this._super() call should actually include the arguments too (e.g. like in https://github.com/babel/ember-cli-babel/blob/4ab3d4a0929c6a4c9420a7bd6c15ed24f6d976f6/index.js#L23)
There was a problem hiding this comment.
ok, I used argument destructuring.
There was a problem hiding this comment.
I think argument destructuring is not available on Node 4 though, and since we don't run Ember CLI itself through Babel we can't use it yet.
lib/models/addon.js
Outdated
| this._super(parent, project); | ||
| this._someCustomSetup(); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
could you change the example to:
init() {
this._super.init && this._super.init.apply(this, arguments);
this._someCustomSetup();
}
|
awesome, thanks. could you squash the commits? |
mattmarcum
force-pushed
the
6780-docuement-addon-init-method
branch
from
07175a0
to
ec68d39
Compare
|
squashed |
|
muchas gracias! @homu r+ |
|
📌 Commit ec68d39 has been approved by |
…Turbo87 [BUGFIX] Add yuidocs for the addon:init method Addresses [6780](#6780) Just starting the documentation process. Let me know if there's any other relevant info to add in here.
|
☀️ Test successful - status |
Addresses 6780
Just starting the documentation process. Let me know if there's any other relevant info to add in here.