Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis multiple blank line cleanup and if block code consolidation #7169

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

kellyselden
Copy link
Member

I had Travis file cleanup in #7066 that was closed. This takes the good cleanup without the firefox stuff.

@Turbo87
Copy link
Member

Turbo87 commented Jun 30, 2017

hmm... are those files not checked by any tests?

@Turbo87 Turbo87 added the bug label Jun 30, 2017
@stefanpenner
Copy link
Contributor

Likely not a bad idea to load them via yml parser and ensure the internal state is as expected

@Turbo87
Copy link
Member

Turbo87 commented Jun 30, 2017

Likely not a bad idea to load them via yml parser and ensure the internal state is as expected

sounds nice in theory, but might be overkill for what we're doing here 🤔

@stefanpenner
Copy link
Contributor

@Turbo87 future PR is fine

@stefanpenner stefanpenner merged commit 2dc3da8 into ember-cli:master Jun 30, 2017
@kellyselden
Copy link
Member Author

I though about fixtures to test these files too. I think I will add them. It's so easy to regress the formatting in these files that I think it will be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants