Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the shims messaging #7685

Merged
merged 1 commit into from
Mar 20, 2018
Merged

fix the shims messaging #7685

merged 1 commit into from
Mar 20, 2018

Conversation

kellyselden
Copy link
Member

It was missing the termination condition when addons is empty causing it to always be false.

@stefanpenner
Copy link
Contributor

stefanpenner commented Mar 17, 2018 •
edited
Loading

do we need a quick unit/regression test?

@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2018

Yeah, probably

@kellyselden
Copy link
Member Author

Added a test.

@rwjblue rwjblue merged commit 758d269 into ember-cli:master Mar 20, 2018
@kellyselden kellyselden deleted the shims branch March 20, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellyselden @stefanpenner @rwjblue