Remove ember-ajax from addon blueprint #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Oct 17, 2018
|
As far as I could see module-unification-addon inherits from addon in someway, and I could not find similar code to that of addon to remove ember-data and the like. So what I ended up doing was just removing ember-ajax from module-unification-addon test fixture file. I hope this works. |
|
The builds failed, but I don't think it is caused by my changes. Do I have to do anything to make sure my changes can be merged, or will someone look through the build logs and decide if it is okay to merge? |
Turbo87
approved these changes
Oct 19, 2018
rwjblue
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7760