Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore .env* files #8308

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

kellyselden
Copy link
Member

Because lots of people have these, and since npm doesn't merge .npmignore files from system unlike .gitignore, we can be nice to people and prevent the mistake.

@Turbo87
Copy link
Member

Turbo87 commented Dec 18, 2018

@kellyselden this is not a bugfix though, so should not target LTS or release. I would suggest to aim this at beta.

@kellyselden kellyselden changed the base branch from lts-3-4 to beta December 18, 2018 16:45
@kellyselden
Copy link
Member Author

retargetted

@Turbo87 Turbo87 merged commit baab8d8 into ember-cli:beta Dec 18, 2018
@kellyselden kellyselden deleted the ignore-dot-env-files branch December 18, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants