preprocessTemplates is called only once in MU layout
#8414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppcano
changed the title
preprocessTemplates is called only once in MU layoutpreprocessTemplates is called only once in MU layout
ppcano
force-pushed
the
fix-mu-process-templates
branch
from
da739cd
to
7f1866f
Compare
ppcano
changed the title
preprocessTemplates is called only once in MU layoutpreprocessTemplates is called only once in MU layout
|
/cc @rwjblue |
rwjblue
approved these changes
Feb 14, 2019
| exclude: ['templates/**/*'], | ||
| annotation: 'MU Templates', | ||
| }); | ||
| mu = this._debugTree(mu, 'mu-layout:tree:template'); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8196 and supersedes #8197. The PR avoid
preprocessTemplatesbeing called twice on the same templates.The implementation follows the same type of changes that were done at #8289 where
defaultPackager.packageStylesbecame the function to process styles (Classic and MU layout).This PR changes
defaultPackager.processTemplatesto be the only function to process templates (Classic and MU layout).defaultPackager.processSrcbecomesdefaultPackager.processJavascriptSrcand will only process JS/TS files for MU apps.