Update cacheKeyForTree to cache the treeForVendor #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an ember addon has a modified/overrided treeFor* method, the result of this treeFor method won't get cached, according to https://github.com/ember-cli/ember-cli/blob/master/lib/models/addon.js#L728. The `cacheKeyForTree('vendor')` will always return `null`, so if "ember-fetch" was depended by the app and other addons(e.g ember-data), it will recalculate the "treeForVendor" every time. This PR make sure that the result of "treeForVendor" will be cached.
xg-wang
requested changes
Apr 17, 2019
xg-wang
approved these changes
Apr 18, 2019
|
Released as v6.5.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ember addon has a modified/overrided treeFor* method, the result of this treeFor method won't get cached, according to https://github.com/ember-cli/ember-cli/blob/master/lib/models/addon.js#L728. The
cacheKeyForTree('vendor')will always returnnull, so if "ember-fetch" was depended by the app and other addons(e.g ember-data), it will recalculate the "treeForVendor" every time.This PR make sure that the result of "treeForVendor" will be cached.