Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

Use native classes in app/router.js #149

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Use native classes in app/router.js #149

merged 1 commit into from
Aug 20, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 20, 2019

@rwjblue rwjblue mentioned this pull request Aug 20, 2019
Closed
4 tasks
NullVoxPopuli
NullVoxPopuli approved these changes Aug 20, 2019
View reviewed changes
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- will merge when C.I. passes

@rwjblue
Copy link
Member Author

rwjblue commented Aug 20, 2019

CI is happy 😸

@rwjblue rwjblue merged commit 4ca2cf1 into ember-cli:master Aug 20, 2019
@rwjblue rwjblue deleted the native-class-router branch August 20, 2019 14:46
@chancancode
Copy link
Contributor

we can do export default class Router now instead of doing it at the end :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support native classes in app/router.js
3 participants
@rwjblue @chancancode @NullVoxPopuli