Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Regression in dummy app layout #187

Merged
merged 1 commit into from
Oct 6, 2020
Merged

fix: Regression in dummy app layout #187

merged 1 commit into from
Oct 6, 2020

Conversation

raido
Copy link
Contributor

@raido raido commented Oct 6, 2020

This commit removed class bindings for nested template component causing rendering issues - 7138ee2#diff-247370af94a867a6f232e4085fed5afdL7

@knownasilya
Copy link
Contributor

Ah, forgot to put those back. Was going to convert to tagless component but noticed heavy use of element and decided to do it later.

@knownasilya knownasilya merged commit 15a380f into ember-cli:master Oct 6, 2020
@knownasilya
Copy link
Contributor

Thanks!

@raido
Copy link
Contributor Author

raido commented Oct 6, 2020

Ah, forgot to put those back. Was going to convert to tagless component but noticed heavy use of element and decided to do it later.

I was looking into converting it to Glimmer component but it is not straight forward due to current data flow.

Outer layers need changes as well in one go.

@raido raido deleted the fix-dummy-app-layout branch October 14, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raido @knownasilya