Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use volta for ci + support Ember Beta v4.x and Canary #223

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 25, 2021

ember 4 requires auto-import@v2

Depends on: #218

- [ ] Blocked by v7.x major release - #222

@raido raido changed the title Use volta for ci + suppert Ember Canary Use volta for ci + support Ember Beta and Canary Oct 25, 2021
@raido raido changed the title Use volta for ci + support Ember Beta and Canary Use volta for ci + support Ember Beta v4.x and Canary Oct 25, 2021
Copy link
Contributor

@raido raido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also move ember-beta test scenario in CI file back to "not allowed to fail" ember-try-sceranios list?

We temporarily allowed ember-beta ember-try scenario to fail on CI so we could get other scenarios green for fix PRs.
Copy link
Contributor

@raido raido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@raido raido merged commit 46f5600 into ember-cli:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants