Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge page-title services #241

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

bertdeblock
Copy link
Member

@bertdeblock bertdeblock commented Oct 14, 2022

The page-title-list service is now merged into the page-title service. The page-title service is now the only service shipped by this addon. Users who were importing and extending the page-title-list service for whatever reason, should just import and extend the page-title service instead. Users who defined the page-title-list service as a dependency for an engine, should also just use the page-title service instead.

Closes #230.

@bertdeblock
Copy link
Member Author

The failures in the ember-lts-3.24 scenario don't immediately ring a bell, but pretty sure they're unrelated to the changes in this PR. We should probably drop support for versions older than v3.28 as well.

@knownasilya knownasilya merged commit 85b2cc4 into ember-cli:master Oct 14, 2022
@kategengler kategengler added the breaking this will be a breaking change, and a new major version should be released label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking this will be a breaking change, and a new major version should be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge page-title and page-title-list services?
3 participants