Remove /// <reference types='ember-sources/types #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to be clear, I believe these only cause issues if you're still using the DefinitelyTyped Ember types rather than already using the stable types. I can confirm that manually deleting the triple-slash directives fixed my issues locally |
|
Tested with this branch locally and this fixes the issue for me |
NullVoxPopuli
force-pushed
the
remove-triple-slash-references
branch
from
dc2c1ac to
27bced6
Compare
Merged
Windvis
added a commit
to Windvis/ember-breadcrumb-trail
that referenced
this pull request
Feb 3, 2024
This copies the setup from ember-page-title: ember-cli/ember-page-title#283
Windvis
added a commit
to Windvis/ember-breadcrumb-trail
that referenced
this pull request
Aug 9, 2024
This copies the setup from ember-page-title: ember-cli/ember-page-title#283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These break consumers when they are included in v2 addon output.
(
)
From TS' perspective, this is correct behavior, so this PR uses a tool I made to just remove the references.