allow all types, not just view to be resolved via namespace
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stefanpenner
commented
Jan 21, 2015
stefanpenner
commented
- add tests (was having issues with the old ruby tooling, wont have time till after work to fix)
|
@rwjblue / @bcardarella r? |
|
@stefanpenner https://github.com/ember-cli/ember-resolver/blob/master/packages/ember-resolver/tests/core_test.js#L66-L112 ember-resolver can already look up any type in other namespaces. That specific line is intended for the alternate form of view lookups which I assumed was not necessary for other types based upon ember-resolvers existing test suite. |
|
@bcardarella i'll add my scenario as an example tonight. I was also quite surprised. |
|
FWIW I've been using the namespace resolving with ember-validations and ember-cli-i18n without any issue |
|
@stefanpenner @bcardarella I've added a new pull request fixing this (#92) |
kratiahuja
pushed a commit
to kratiahuja/ember-resolver
that referenced
this pull request
Aug 5, 2016
add stats, and pedantic tests against said stats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.