Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Co-location support (emberjs/rfcs#481) #164

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Co-location support (emberjs/rfcs#481) #164

merged 1 commit into from
Aug 11, 2019

Conversation

chancancode
Copy link
Contributor

@chancancode chancancode requested review from Turbo87 and rwjblue August 10, 2019 23:38
chancancode added a commit to ember-cli/ember-cli-htmlbars that referenced this pull request Aug 10, 2019
@rwjblue rwjblue merged commit de6f574 into master Aug 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the co-location branch August 11, 2019 12:21
@rwjblue rwjblue changed the title Co-location support (RFC #481) Co-location support (emberjs/rfcs#481) Aug 12, 2019
@rwjblue
Copy link
Member

rwjblue commented Aug 12, 2019

@chancancode - This is now fully released (updated in babel-plugin-ember-modules-api-polyfill and then in ember-cli-babel), folks need to ensure they use ember-cli-babel@7.9.0 and these imports will be present.

@chancancode
Copy link
Contributor Author

chancancode commented Aug 12, 2019

Thank you! I changed our branch on ember-cli-htmlbars to use the global anyway so I don’t think anything is needing this. We could revert the ember-cli-htmlbars commit if we think it’s better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants