Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to run on Node 10 #280

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Update CI to run on Node 10 #280

merged 1 commit into from
Apr 24, 2020

Conversation

locks
Copy link
Contributor

@locks locks commented Apr 24, 2020 •
edited
Loading

I'm seeing a bunch of dependabot PRs that seem to be failing because they bumped the minimum Node to v10. They don't seem to bring much benefit, but at the very least we should run the tests also on newer versions? Opening this up for discussion.

@locks locks requested a review from Turbo87 April 24, 2020 14:07
Turbo87
Turbo87 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this project is only exporting JSON files and using JS files only at dev-time I guess it's fine to merge this even without a major version bump 👍

@rwjblue
Copy link
Member

rwjblue commented Apr 24, 2020

Ya, agree

@rwjblue rwjblue merged commit f04cd27 into master Apr 24, 2020
@rwjblue rwjblue deleted the locks-patch-1 branch April 24, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locks @rwjblue @Turbo87