Add gjs/gts highlighting to GitHub

[NullVoxPopuli]

We need 200 unique repos before they'll accept a PR:

https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language
https://github.com/github/linguist/blob/master/CONTRIBUTING.md#adding-a-language

Here is a search for all the gjs/gts files currently on GitHub.
at this time, I don't know how to count repos from these results -- the repos mentioned on the right-hand side of the page feel very incomplete.

[wagenet]

Do private repos count? Also, could I just open 200 repos each with one .gts file? :D

[dfreeman]

For what it's worth, I've been using this search which returns a few more hits, all of which are legitimate as far as I can tell.

It looks like Code Search will only give you the first 100 results, though, so I wonder if the repo list there is just the repositories that contain those hits?

Do private repos count?

I've hunted for an answer to that question in the past and haven't been able to find one. Might be worth asking somewhere?

[gitKrystan]

Per the github-linguist documentation, the rule for adding a new extension is usually the following:

We try only to add new extensions once they have some usage on GitHub. In most cases we prefer that each new file extension be in use in at least 200 unique :user/:repo repositories before supporting them in Linguist.

-- CONTRIBUTING.md

But, the way they were using to determine "200 unique :user/:repo repositories" is in flux with the new GitHub code search feature, so they are temporarily using the following rules as a proxy of determining the above:

• at least 2000 files per extension indexed in the last year (the number you see at the top of the search results), unless the extension is expected to only occur once per repo, then 200 files.
• with a reasonable distribution across unique :user/:repo combinations assessed by manually and randomly clicking through the results.

-- github-linguist/linguist#5756

Using a quick search, it looks like there are currently over 900 gjs/gts files on GitHub: search: "(path:.gjs OR path:.gts) AND (content:@ember OR content:@glimmer OR content:<template>) "

(Notably, there is already support for another .gts extension--Gerber file--but we should be able to disambiguate, as I've done in the search above and following these docs. @wycats noted that Gerber files seem to always start with "G0X" and have lines starting with "%".)

In the meantime, @wagenet noted a way to use the documented override strategies to get at least the JS/TS portion of a gts/gjs file highlighted. Just add the following to a .gitattributes file in the top level of the repository:

*.gjs linguist-language=js linguist-detectable
*.gts linguist-language=ts linguist-detectable

Example:

[NullVoxPopuli]

I think we should include markdown codefences in our search, via this:

https://github.com/search?q=%28%28path%3A*.gjs+OR+path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E%29%29+OR+%28path%3A*.md+AND+content%3A%3Ctemplate%3E+AND+content%3Agjs%29%29&type=code

This puts us at 1.8k files, which is ~ 200 short of the required 2000.
(this includes vue... so.. 🙃 )

If I try to exclude mentions of vue, that puts us back down at 1200 for now: https://github.com/search?q=%28%28path%3A*.gjs+OR+path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E%29%29+OR+%28path%3A*.md+AND+content%3A%3Ctemplate%3E+AND+content%3Agjs+AND+%28NOT+content%3Avue%29%29%29&type=code

I have more gjs/gts tests to write.

[gilest]

Draft PR for adding gts/gjs highlighting support to GitHub. Getting feedback here before I target the upstream Lingust repo gilest/linguist#1

[gilest]

PR opened github-linguist/linguist/pull/6556

[jakebixby]

I think we should include markdown codefences in our search, via this:

github.com/search?q=%28%28path%3A*.gjs+OR+path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E%29%29+OR+%28path%3A*.md+AND+content%3A%3Ctemplate%3E+AND+content%3Agjs%29%29&type=code

This puts us at 1.8k files, which is ~ 200 short of the required 2000. (this includes vue... so.. 🙃 )

If I try to exclude mentions of vue, that puts us back down at 1200 for now: github.com/search?q=%28%28path%3A*.gjs+OR+path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E%29%29+OR+%28path%3A*.md+AND+content%3A%3Ctemplate%3E+AND+content%3Agjs+AND+%28NOT+content%3Avue%29%29%29&type=code

I have more gjs/gts tests to write.

It's odd that adding the markdown bit to the query reduces the count, whereas without (see below) I see 2.3k files, which I would assume meets the threshold? https://github.com/search?q=((path:*.gjs+OR+path:*.gts)+AND+(content:%3Ctemplate%3E))&type=code

EDIT
Oh, I see they are asking for the counts to be per file extension, which is currently only 1.5k for gjs
https://github.com/search?q=((path:*.gjs)+AND+(content:%3Ctemplate%3E))&type=code

and 1k for gts
https://github.com/search?q=((path:*.gts)+AND+(content:%3Ctemplate%3E))&type=code

I wonder if it would be worth asking engineers at some of the companies using ember to create individual repos with gjs and gts files? If forking counts, it could be relatively quick to build up 200 repos. Maybe we could achieve by forking a tutorial app and doing workshops to introduce folks to the basics?

[NullVoxPopuli]

Looks like there was a syntax issue the the previous markdown query.

Fixed here:
https://github.com/search?q=%28%28path%3A*.gjs+OR+path%3A*.gts%29+AND+%28content%3A%3Ctemplate%3E%29%29+OR+%28path%3A*.md+AND+content%3A%3Ctemplate%3E+AND+%28%28content%3Agjs+OR+content%3Agts%29+AND+%28NOT+content%3Avue%29%29%29&type=code

Which gives us 2.7k files

[fdeters]

Just saw that Glimmer JS is supported as of github-linguist v7.28.0 🎉

Syntax highlighting is working in my repos, but looks like we're still waiting to see Glimmer JS in the language breakdown chart.

[deanylev]

@fdeters seems to only be for .gjs files, not .gts files 😕

[NullVoxPopuli]

Gts is soon, we've just crossed the threshold for what was needed to allow us to submit a pr

[NullVoxPopuli]

This is done!