-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-874 migrate some components over to polaris #1091
Conversation
CC-874 Start using .gts files
Let's start using Ember's new "template imports" format: https://github.com/ember-template-imports/ember-template-imports. Test it out on 2-3 small components to start with, and note any issues that we run into. |
updated just before the base template. not sure how that would look like. for effort to update: around 5 to 10 mins to convert and test as it's mostly just copy and paste per component. it only takes longer if there are broken imports. |
@libmartinito what do you mean by "base template" here? |
Okay so one major problem I'm noticing here is that there's no syntax highlighting for |
i guess i should just say templates haha. templates receive data from controllers which in turn get their data from the route model. if i convert a template to a .gts file, does it mean that i get access to the route model directly and the controller goes away? maybe i could play around with that the next series of component migrations to polaris |
Checklist:
[percy]
in the message to trigger)