Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix file menu in mobile and medium sizes #692

Merged
merged 3 commits into from
Mar 2, 2020
Merged

fix file menu in mobile and medium sizes #692

merged 3 commits into from
Mar 2, 2020

Conversation

knownasilya
Copy link
Contributor

Screen Shot 2020-03-02 at 11 15 45 AM

Screen Shot 2020-03-02 at 11 15 58 AM

Screen Shot 2020-03-02 at 11 16 08 AM

@knownasilya knownasilya requested a review from Gaurav0 March 2, 2020 16:17
@knownasilya knownasilya self-assigned this Mar 2, 2020
Gaurav0
Gaurav0 suggested changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@Gaurav0 Gaurav0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Looks like the add submenu position is a little off on medium/desktop sizes. Can you line it up next to the arrow (while keeping it the same way in mobile) ?

@knownasilya
Copy link
Contributor Author

Are you talking about the vertical position?

@Gaurav0
Copy link
Contributor

Gaurav0 commented Mar 2, 2020

Yes.

@knownasilya knownasilya requested a review from Gaurav0 March 2, 2020 19:20
Gaurav0
Gaurav0 approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@Gaurav0 Gaurav0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@Gaurav0 Gaurav0 merged commit 07f11b6 into ember-cli:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gaurav0 Gaurav0 Gaurav0 approved these changes

Assignees

@knownasilya knownasilya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knownasilya @Gaurav0