Skip to content

Commit

Permalink
docs: add link to Ember function prototype extensions deprecation RFC (
Browse files Browse the repository at this point in the history
  • Loading branch information
bmish authored Aug 16, 2022
1 parent 6140738 commit 7f7759b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions docs/rules/no-function-prototype-extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

By default, Ember extends certain native JavaScript objects with additional methods. This can lead to problems in some situations. One example is relying on these methods in an addon that is used inside an app that has the extensions disabled.

The prototype extensions for the `function` object will likely become deprecated in the future.
The prototype extensions for the `function` object were deprecated in [RFC #272](https://rfcs.emberjs.com/id/0272-deprecation-native-function-prototype-extensions).

Use computed property syntax, observer syntax, or module hooks instead of `.property()`, `.observes()` or `.on()` in Ember modules.

Expand Down Expand Up @@ -48,7 +48,8 @@ export default Component.extend({

## References

* [Ember Prototype extensions documentation](https://guides.emberjs.com/release/configuring-ember/disabling-prototype-extensions/)
* [Ember prototype extensions documentation](https://guides.emberjs.com/release/configuring-ember/disabling-prototype-extensions/)
* [Ember function prototype extensions deprecation RFC](https://rfcs.emberjs.com/id/0272-deprecation-native-function-prototype-extensions)

## Related Rules

Expand Down
4 changes: 2 additions & 2 deletions docs/rules/no-string-prototype-extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

By default, Ember extends certain native JavaScript objects with additional methods. This can lead to problems in some situations. One example is relying on these methods in an addon that is used inside an app that has the extensions disabled.

The prototype extensions for the `String` object were deprecated in [RFC #236](https://emberjs.github.io/rfcs/0236-deprecation-ember-string.html).
The prototype extensions for the `String` object were deprecated in [RFC #236](https://rfcs.emberjs.com/id/0236-deprecation-ember-string/).

## Rule Details

Expand Down Expand Up @@ -59,7 +59,7 @@ dasherize('myString');
## References

* [Ember prototype extensions documentation](https://guides.emberjs.com/release/configuring-ember/disabling-prototype-extensions/)
* [Ember String prototype extensions deprecation RFC](https://emberjs.github.io/rfcs/0236-deprecation-ember-string.html#string-prototype-extensions)
* [Ember String prototype extensions deprecation RFC](https://rfcs.emberjs.com/id/0236-deprecation-ember-string/)

## Related Rules

Expand Down

0 comments on commit 7f7759b

Please sign in to comment.