Disable order-in-* rules by default

ember-cli · Nov 15, 2017 · c390307 · c390307
1 parent 042b134
commit c390307
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -111,10 +111,10 @@ The `--fix` option on the command line automatically fixes problems reported by
 
 |    | Rule ID | Description |
 |:---|:--------|:------------|
-| :white_check_mark: | [order-in-components](./docs/rules/order-in-components.md) | Enforces proper order of properties in components |
-| :white_check_mark: | [order-in-controllers](./docs/rules/order-in-controllers.md) | Enforces proper order of properties in controllers |
-| :white_check_mark: | [order-in-models](./docs/rules/order-in-models.md) | Enforces proper order of properties in models |
-| :white_check_mark: | [order-in-routes](./docs/rules/order-in-routes.md) | Enforces proper order of properties in routes |
+|  | [order-in-components](./docs/rules/order-in-components.md) | Enforces proper order of properties in components |
+|  | [order-in-controllers](./docs/rules/order-in-controllers.md) | Enforces proper order of properties in controllers |
+|  | [order-in-models](./docs/rules/order-in-models.md) | Enforces proper order of properties in models |
+|  | [order-in-routes](./docs/rules/order-in-routes.md) | Enforces proper order of properties in routes |
 | :white_check_mark: | [use-brace-expansion](./docs/rules/use-brace-expansion.md) | Enforces usage of brace expansion |
 
 ### Deprecated

diff --git a/lib/recommended-rules.js b/lib/recommended-rules.js
@@ -24,10 +24,10 @@ module.exports = {
   "ember/no-old-shims": "error",
   "ember/no-on-calls-in-components": "error",
   "ember/no-side-effects": "error",
-  "ember/order-in-components": "error",
-  "ember/order-in-controllers": "error",
-  "ember/order-in-models": "error",
-  "ember/order-in-routes": "error",
+  "ember/order-in-components": "off",
+  "ember/order-in-controllers": "off",
+  "ember/order-in-models": "off",
+  "ember/order-in-routes": "off",
   "ember/require-super-in-init": "error",
   "ember/routes-segments-snake-case": "error",
   "ember/use-brace-expansion": "error",

diff --git a/lib/rules/order-in-components.js b/lib/rules/order-in-components.js
@@ -37,7 +37,7 @@ module.exports = {
     docs: {
       description: 'Enforces proper order of properties in components',
       category: 'Stylistic Issues',
-      recommended: true
+      recommended: false
     },
     fixable: null // or "code" or "whitespace"
   },

diff --git a/lib/rules/order-in-controllers.js b/lib/rules/order-in-controllers.js
@@ -27,7 +27,7 @@ module.exports = {
     docs: {
       description: 'Enforces proper order of properties in controllers',
       category: 'Stylistic Issues',
-      recommended: true
+      recommended: false
     },
     fixable: null, // or "code" or "whitespace"
   },

diff --git a/lib/rules/order-in-models.js b/lib/rules/order-in-models.js
@@ -23,7 +23,7 @@ module.exports = {
     docs: {
       description: 'Enforces proper order of properties in models',
       category: 'Stylistic Issues',
-      recommended: true
+      recommended: false
     },
     fixable: null, // or "code" or "whitespace"
   },

diff --git a/lib/rules/order-in-routes.js b/lib/rules/order-in-routes.js
@@ -35,7 +35,7 @@ module.exports = {
     docs: {
       description: 'Enforces proper order of properties in routes',
       category: 'Stylistic Issues',
-      recommended: true
+      recommended: false
     },
     fixable: null // or "code" or "whitespace"
   },