Additional false positives with no-array-prototype-extensions rule

[gilest]

Further to #1534 there are additional false positives when this rule is run against ember-file-upload.

• .clear() on a Set (probably on a Map, too)
• RSVP.reject()

If I have time tomorrow I'll open a PR to address.

[bmish]

Thanks a lot for this report! Ignoring RSVP should be easy using the same technique as the last fix:

eslint-plugin-ember/lib/rules/no-array-prototype-extensions.js

Line 60 in 42a3e85

const KNOWN_NON_ARRAY_FUNCTION_CALLS = new Set([

For Map / Set / WeakMap / WeakSet / or the tracked-built-ins versions of those, we'll need to come up with some heuristics to detect when the variables are those data types. Some of my ideas:

• Ignore variables with "map" or "set" in the name
• Ignore variables where we can statically determine their value or that at least one of their initializations was to a map/set

[bmish]

I began a fix with one of the heuristics in #1538.

[gilest]

Attempted to cover the remaining case in #1539

Would appreciate your review @bmish

[bmish]

I'm reopening this because there are still some improvements needed to cover the original scenario:

1. Class property definitions (eslint-utils' findVariable function doesn't handle class properties?)

class MyClass {
  foo = new Set();
  myFunc() { this.foo.clear() }
}

2. TypeScript with private identifiers (TypeScript PrivateIdentifier node type not handled?)

class MyClass {
  #foo: Set<UploadFile> = new Set();
  myFunc() {
    this.#foo.clear();
  }
}

I'll try to look into how to improve upon my solution from #1538 in the coming week.

[bmish]

@gilest all the necessary fixes should now be available in v11.0.3. Let me know if you have any other issues. Thanks for testing and reporting!

[gilest]

Awesome work @bmish 🙌🏻