Fix false positives with RSVP.Promise.reject() in no-array-prototype-extensions rule
#1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
no-array-prototype-extensions-rsvp-reject
branch
from
ee19d35 to
02ee0b7
Compare
mongoose700
approved these changes
Jul 29, 2022
bmish
force-pushed
the
no-array-prototype-extensions-rsvp-reject
branch
from
02ee0b7 to
1a8806c
Compare
lin-ll
approved these changes
Jul 29, 2022
ef4
added a commit
that referenced
this pull request
Aug 10, 2022
The `no-array-prototype-extensions` rule is trying to do an impossible thing. It's going to produce a never-ending stream of false positives. You cannot statically tell which calls are actually relying on the array prototype extensions. A correct implementation is probably possible, but only in typescript (where eslint rules can take advantage of type information), not in javascript. I'm all in favor of pushing people away from using array prototype extensions, but that is going to require runtime implementation. It cannot be checked statically. A rule that is so often wrong will just encourage people not to trust it anyway. I don't think it should be in the recommended set. Examples: #1561 #1552 #1547 #1546 #1544 #1543 #1538 #1539 #1536
bmish
added a commit
that referenced
this pull request
Aug 18, 2022
…#1562) * Remove no-array-prototype-extensions from recommended The `no-array-prototype-extensions` rule is trying to do an impossible thing. It's going to produce a never-ending stream of false positives. You cannot statically tell which calls are actually relying on the array prototype extensions. A correct implementation is probably possible, but only in typescript (where eslint rules can take advantage of type information), not in javascript. I'm all in favor of pushing people away from using array prototype extensions, but that is going to require runtime implementation. It cannot be checked statically. A rule that is so often wrong will just encourage people not to trust it anyway. I don't think it should be in the recommended set. Examples: #1561 #1552 #1547 #1546 #1544 #1543 #1538 #1539 #1536 * docs: mentioned recommend rule removal in changelog * docs: explain why no-array-prototype-extensions is not in recommended config Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1537 (some related scenarios).