Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple documentation typo #240

Closed
thebluejay opened this issue Mar 17, 2018 · 1 comment
Closed

Simple documentation typo #240

thebluejay opened this issue Mar 17, 2018 · 1 comment

Comments

@thebluejay
Copy link
Contributor

The documentation for the no-jquery rule (docs/rules/no-jquery.md) has a confusing typo, where the second example of correct code for this rule, is actually incorrect.

Currently the example is:

import $ from 'jquery';

export default Component.extend({
  click() {
    document.body.classList.add('expanded');
  }
});

When it should be lacking the jQuery import like so:

export default Component.extend({
  click() {
    document.body.classList.add('expanded');
  }
});
@twokul
Copy link
Contributor

twokul commented Mar 17, 2018

@thebluejay do you mind submitting a quick PR to address the issue?

thebluejay added a commit to thebluejay/eslint-plugin-ember that referenced this issue Mar 17, 2018
kellyselden pushed a commit that referenced this issue Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants