Catch willDestroy Glimmer component hook in require-super-in-lifecycle-hooks rule
#1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
changed the title
require-super-in-life-cycle-hooks rule
bmish
force-pushed
the
require-super-in-lifecycle-hooks-glimmer
branch
from
88c5afa to
d527ab0
Compare
…ecycle-hooks rule
bmish
changed the title
require-super-in-life-cycle-hooks rulewillDestroy component hook in require-super-in-life-cycle-hooks rule
bmish
force-pushed
the
require-super-in-lifecycle-hooks-glimmer
branch
from
d527ab0 to
648a463
Compare
bmish
changed the title
willDestroy component hook in require-super-in-life-cycle-hooks rulewillDestroy Glimmer component hook in require-super-in-life-cycle-hooks rule
bmish
force-pushed
the
require-super-in-lifecycle-hooks-glimmer
branch
from
648a463 to
96afd81
Compare
bmish
changed the title
willDestroy Glimmer component hook in require-super-in-life-cycle-hooks rulewillDestroy Glimmer component hook in require-super-in-lifecycle-hooks rule
This was referenced Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1035.