Improve detection of global window methods in prefer-ember-test-helpers rule
#1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test-helpers rule Eliminates all of the custom logic in the rule for detecting if the `blur` / `find` / `focus` window functions are defined locally and replaces it with the ReferenceTracker class from eslint-utils. There was no specific known bug with the rule before, but this refactor will make the rule more robust in its ability to detect calls to the global window functions that we are trying to disallow. https://eslint-utils.mysticatea.dev/api/scope-utils.html#referencetracker-class
|
Nice, thanks for doing this @bmish! |
This was referenced Mar 11, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates all of the custom logic in the rule for detecting if the
blur/find/focuswindow functions are defined locally and replaces it with the ReferenceTracker class from eslint-utils.There was no specific known bug with the rule before, but this refactor will make the rule more robust in its ability to detect calls to the global window functions that we are trying to disallow.
CC: @fierysunset