Improve detection of globals and catch additional jQuery function calls in no-jquery rule

[BarryThePenguin]

I ran into three situations when using the no-jquery rule that I thought might be worth fixing. I've added test cases for each.

1. MemberExpression like $.extend() does not trigger the rule
2. MemberExpression like this.$.extend() does not trigger the rule
3. A function Parameter like function foo($) { ... } does trigger the rule

For the last one, I'd expect it to not trigger the rule, as eslint cannot know for certain where $ came from..

I put together the failing test cases and spent some time investigating what might need to change. The end result is quite a significant change to how the rule works..

All the existing test cases still work, including the new ones I've added. There may be some history behind the original implementation that I'm not aware of, so I understand if this new approach is too big a change

Fixes #211 #279

[bmish]

Thanks for your work so far!

[bmish]

Remember to include the Ember import statement for this. Alternatively, you could just simplify the entire test case to jQuery.extend() since the rule does not actually care if the Ember component is involved and the Ember component just adds unnecessary clutter to the test case.

[bmish]

Great work on this! This really improves and simplifies these rules.

[BarryThePenguin]

Thank you! I've appreciated your help and feedback with this. I think we've ended up in a good place 👍🏻

[bmish]

@BarryThePenguin it looks like the jquery-ember-run rule could benefit from the same improvements as here, let me know if you're interested to refactor/improve that rule too. I just improved the tests for that rule (#1069) but saw many shortcomings in the rule.

[BarryThePenguin]

I can take a look 👀 What shortcomings did you notice?

[bmish]

@BarryThePenguin the jquery-ember-run rule should be updated to use the ReferenceTracker to detect jQuery calls the same way as the no-jquery rule has been. Right now, it has very naive detection as it just checks a few string names.