Add new "call-super-in-init" rule #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule enforces calling this._super(...arguments) inside init lifecycle hooks. This rule will fire inside Components, Routes, Controllers and Mixins.
michalsnik
suggested changes
Aug 7, 2017
docs/rules/call-super-in-init.md
Outdated
| @@ -0,0 +1,24 @@ | |||
| ## Call _super in init lifecycle hooks | |||
|
|
|||
| ### Rule name: `call-super-in-init` | |||
There was a problem hiding this comment.
I'd call this rule require-super-in-init, it's common way of naming eslint rules when you require something to be present. wdyt?
lib/rules/call-super-in-init.js
Outdated
| docs: { | ||
| description: 'Enforces super calls in init hooks', | ||
| category: 'General', | ||
| recommended: true |
There was a problem hiding this comment.
Let's set this to false so that we can make a minor release and we'll bulk set those recommendations later on in one major release.
lib/rules/call-super-in-init.js
Outdated
| const fnExpressions = utils.findNodes(initPropertyBody, 'ExpressionStatement'); | ||
|
|
||
| const hasSuper = fnExpressions.some((fnExpression) => { | ||
| const fnCallee = fnExpression.expression.callee; |
There was a problem hiding this comment.
We should actually check if fnExpression.expression is CallExpression first.
This will work, but only due to additional check inside isMemberExpression, as the fnCallee in many cases will be undefined. Anyway we should not rely on the additional check inside isMemberExpression and be sure to pass the actual CallExpression there
kevinkucharczyk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #82, I've added a new rule to make sure
_superis called whenever theinitlifecycle hook is being overridden.