Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint rule crash when variable is used as routename #168

Merged

Conversation

cspanring
Copy link
Contributor

@cspanring cspanring commented Nov 13, 2017

Resolves #163

I'm not very familiar with eslint-plugins. If there's a way to resolve the value of a node type "Identifier", I'm happy to change this PR. Couldn't see how or if that's possible.

@Turbo87 Turbo87 changed the title workaround for issue when variable is used as routename Fix lint rule crash when variable is used as routename Nov 15, 2017
@Turbo87 Turbo87 added the bug label Nov 15, 2017
@Turbo87 Turbo87 merged commit b351dbe into ember-cli:master Nov 15, 2017
@cspanring cspanring deleted the workaround-variable-routename-163 branch November 15, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-capital-letters-in-routes will crash the linter if you use variable
2 participants