Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Ember Data store service calls in no-array-prototype-extensions rule #1748

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Ignore Ember Data store service calls in no-array-prototype-extensions rule #1748

merged 1 commit into from
Jan 28, 2023

Conversation

bmish
Copy link
Member

@bmish bmish commented Jan 19, 2023

Partially fixes #1561. Helps reduce false positives.

TODO:

  • Explain why Ember Data calls should be ignored

@bmish bmish added the bug label Jan 19, 2023
@bmish bmish force-pushed the no-array-prototype-extensions-ember-data-store branch from 600e281 to 7a08d5f Compare January 28, 2023 16:06
@bmish bmish marked this pull request as ready for review January 28, 2023 16:06
@bmish bmish changed the title Ignore Ember Data store calls in no-array-prototype-extensions rule Ignore Ember Data store service calls in no-array-prototype-extensions rule Jan 28, 2023
@bmish bmish merged commit 4295eef into ember-cli:master Jan 28, 2023
@bmish bmish deleted the no-array-prototype-extensions-ember-data-store branch January 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Even more false positives with no-array-prototype-extensions rule
1 participant
@bmish