Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ember-eslint-parser to 0.3.6 #2091

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Upgrade ember-eslint-parser to 0.3.6 #2091

merged 9 commits into from
Feb 15, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 13, 2024

Folks are still installing an old parser, see: #2062

We don't actually want to support older than what's specified here.

package.json Outdated Show resolved Hide resolved
…ing an invalid version range. Please use ^. Invalid dependencies include: ember-eslint-parser

1 error
0 warnings
@bmish bmish added the bug label Feb 13, 2024
@patricklx
Copy link
Contributor

Why didn't we see this errors in the parser repo?

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Feb 14, 2024

@patricklx , I think the linkage was maybe wrong -- it's been updated here: ember-tooling/ember-eslint-parser#52
(and correctly fails)

@NullVoxPopuli NullVoxPopuli changed the title Upgrade ember-eslint-parser to 0.3.4 Upgrade ember-eslint-parser to 0.3.5 Feb 14, 2024
@NullVoxPopuli NullVoxPopuli changed the title Upgrade ember-eslint-parser to 0.3.5 Upgrade ember-eslint-parser to 0.3.6 Feb 14, 2024
@NullVoxPopuli NullVoxPopuli requested a review from bmish February 14, 2024 16:23
@NullVoxPopuli
Copy link
Contributor Author

@bmish @patricklx, should be good to go now

@bmish
Copy link
Member

bmish commented Feb 15, 2024

@patricklx can you approve when you think this is ready? Then I'll release this.

@bmish bmish merged commit 2cbf929 into master Feb 15, 2024
8 checks passed
@bmish bmish deleted the bump-parser-version branch February 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants