Fix flat config for gts/gjs and noop parser name
#2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
commented
Feb 14, 2024
lib/index.js
Outdated
| @@ -16,6 +16,6 @@ module.exports = { | |||
| }, | |||
| processors: { | |||
| // https://eslint.org/docs/developer-guide/working-with-plugins#file-extension-named-processor | |||
| '<noop>': noop, | |||
| 'noop': noop, | |||
There was a problem hiding this comment.
@NullVoxPopuli @patricklx do we need to export this processor as part of our public API? Is it useful for anyone to import individually from here?
There was a problem hiding this comment.
i thought it's necessary for eslint to find it?
There was a problem hiding this comment.
Not sure. I'll leave it for now with the new name. Hopefully this new name makes sense.
bmish
force-pushed
the
fix-flat-parser
branch
from
de1a980 to
637585a
Compare
NullVoxPopuli
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2061.
Fixes two issues:
parserneeds to be insidelanguagesOptionsin flat config:A config object is using the "parser" key, which is not supported in flat config system. Flat config uses "languageOptions.parser" to override the default parser.https://eslint.org/docs/latest/use/configure/configuration-files-new#configuring-a-custom-parser-and-its-optionsTypeError: Expected string in the form "pluginName/objectName" but found "ember/<noop>".@Techn1x @patricklx @NullVoxPopuli