Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API deprecations blocking eslint v9 compatibility #2153

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

LucasHill
Copy link
Contributor

@LucasHill LucasHill commented Jun 25, 2024

There are a couple deprecations in eslint that are preventing this plugin from working under v9. As this addon already supports the flat config format, I believe these should be the only changes needed to work under v9.

currentSegments deprecation: eslint/eslint#17457
'context.getAncestors` deprecation: https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context.getancestors()

This was my reference for how to fix this rule: https://github.com/eslint/eslint/blob/main/lib/rules/getter-return.js

This was referenced Jun 25, 2024
@LucasHill
Copy link
Contributor Author

LucasHill commented Jun 25, 2024

I may have been a little too confident. I'm finding a few more deprecations. What the current work does do is unblock using the eslint/compat tool for this plugin to work under v9. I'll see how extensive the remaining issues are, but this is mergeable as is or I can try to fix the rest.

@NullVoxPopuli
Copy link
Contributor

thank you!

@NullVoxPopuli NullVoxPopuli merged commit 55cd064 into ember-cli:master Jun 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants