-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better gjs/gts config support for eslint 9 #2191
Provide better gjs/gts config support for eslint 9 #2191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new public import, only available via import, not require
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance to add a test?
I think we'd have to add a whole acceptance suite -- which I'm a fan of -- and we used to have, but I think @bmish removed (because acceptance tests are slow). I think it's valuable enough where we should just do it, and pay the cost of acceptance tests. Is everyone ok with the tradeoff? |
Gonna merge -- acceptance testing infra is too big to lump in to this PR and has some decisions that may need discussing / education / alignment / etc / whatever |
Resolves: #2190
Resolves: #2171 (sorta)
Unblocks: ember-cli/ember-cli#10533