Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better gjs/gts config support for eslint 9 #2191

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Oct 18, 2024

Resolves: #2190
Resolves: #2171 (sorta)

Unblocks: ember-cli/ember-cli#10533

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review October 18, 2024 20:07
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new public import, only available via import, not require

Copy link
Contributor

@patricklx patricklx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance to add a test?

@NullVoxPopuli
Copy link
Contributor Author

any chance to add a test?

I think we'd have to add a whole acceptance suite -- which I'm a fan of -- and we used to have, but I think @bmish removed (because acceptance tests are slow).

I think it's valuable enough where we should just do it, and pay the cost of acceptance tests.

Is everyone ok with the tradeoff?
It would be great to not have to have the slow feedback loop with ember-cli's blueprint system to test changes to the configs in this project.

@NullVoxPopuli
Copy link
Contributor Author

Gonna merge -- acceptance testing infra is too big to lump in to this PR and has some decisions that may need discussing / education / alignment / etc / whatever

@NullVoxPopuli NullVoxPopuli merged commit f040d90 into ember-cli:master Oct 21, 2024
8 checks passed
@NullVoxPopuli NullVoxPopuli deleted the better-gjs-exports branch October 21, 2024 18:53
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the "flat" config exports Example ESLint 9 config
3 participants