Add new "no-old-shims" rule

[Turbo87]

This PR resolves a major part of #86

Example from the documentation:

// GOOD
import Component from '@ember/component'
import EmberObject, { computed } from '@ember/object'
import Service, { inject } from '@ember/service'

// BAD
import Component from 'ember-component';
import EmberObject from 'ember-object';
import computed from 'ember-computed';
import Service from 'ember-service';
import inject from 'ember-service/inject';

The rule also supports eslint --fix

/cc @michalsnik @rwjblue @cibernox

[michalsnik]

Looks really good @Turbo87, thanks for working on this!

[michalsnik]

Nice one!

[michalsnik]

Looks like we can move localName outside of this condition and use const instead:

const localName = specifier.local.name;

[Turbo87]

fixed

[michalsnik]

What do you think about packageName or moduleName instead of source? For a person that looks at this code for the first time it will probably be more understandable. It's just a suggestion though

[Turbo87]

fixed

[michalsnik]

One more thing @Turbo87 I think we should add this rule in https://github.com/netguru/eslint-plugin-ember/blob/master/config/base.js though it will require us to bump a major version of this plugin then instead of a minor. Or maybe you don't think that this rule is that crucial at this moment and we can postpone adding it to default configuration?

[Turbo87]

I'd recommend to try this out for a bit in a minor release and then enable it later if everything works as expected. Since the rule is only useful if you use Babel 6 I'd could also lead to a few false positives if it's enabled by default.

[michalsnik]

Alright, that makes perfect sense to me.

[michalsnik]

Released as v3.6.0 🚀 Thanks @Turbo87