Detecting computed properties with MemberExpressions #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsnik
suggested changes
Jul 14, 2017
| @@ -321,6 +321,15 @@ eslintTester.run('order-in-components', rule, { | |||
| });`, | |||
| parserOptions: { ecmaVersion: 6, sourceType: 'module' }, | |||
| }, | |||
| { | |||
| code: `export default Component.extend({ | |||
| foo: computed(function() { | |||
There was a problem hiding this comment.
Let's add one more test - failing one with computed().volatile in wrong order
lib/utils/ember.js
Outdated
| @@ -129,6 +129,9 @@ function isObserverProp(node) { | |||
| } | |||
|
|
|||
| function isComputedProp(node) { | |||
| if (utils.isMemberExpression(node.callee) && utils.isCallExpression(node.callee.object)) { | |||
| return isModule(node.callee.object, 'computed') && utils.isIdentifier(node.callee.property); | |||
There was a problem hiding this comment.
We were speaking about white listing four methods that are supported on CPs (meta, property, readOnly and volatile regarding https://www.emberjs.com/api/ember/2.14.0/classes/Ember.ComputedProperty). Are you going to add them?
jbandura
force-pushed
the
83-support-member-functions
branch
from
1e374eb
to
a953da0
Compare
michalsnik
approved these changes
Jul 16, 2017
|
Good job @jbandura ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83
Problem:
Linter doesn't recognize following code as a computed property:
Solution:
The computed property is determined based on whether the node is a
CallExpressionwithIdentifierof typecomputedas callee. However in the above case, we have aMemberExpression. The solution involves checking forMemberExpressionwith computedCallExpression.