add define.default #138
Open
add define.default #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
define-default
branch
from
d0cf32c
to
b5754d5
Compare
kellyselden
reviewed
Aug 16, 2018
|
|
||
| ```js | ||
| define('foo', [], () => 'hi'); | ||
| define.default('foo', 'foo/bar/baz'); |
There was a problem hiding this comment.
I think your params are swapped here
There was a problem hiding this comment.
Ya, confirm. Also in the section header...
rwjblue
requested changes
Aug 30, 2018
|
|
||
| ```js | ||
| define('foo', [], () => 'hi'); | ||
| define.default('foo', 'foo/bar/baz'); |
There was a problem hiding this comment.
Ya, confirm. Also in the section header...
| @@ -265,8 +265,9 @@ var loader, define, requireModule, require, requirejs; | |||
| // we don't support all of AMD | |||
| // define.amd = {}; | |||
|
|
|||
| function Alias(id) { | |||
| function Alias(id, prop) { | |||
There was a problem hiding this comment.
This doesn't seem used, revert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.