Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store the noconflict aliases in the global loader object #205

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rajasegar
Copy link

Fixes #204

@rajasegar rajasegar changed the title No conflict Store the noconflict aliases in the global loader object Jan 18, 2021
return window[loader.__aliases.require](resolve(dep, id));
} else {
return require(resolve(dep, id));
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, can be written like this:

const requireReference =
  loader.__aliases && loader.__aliases.require
    ? window[loader.__aliases.require]
    : require;

return requireReference(resolve(dep, id));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store the noconflict aliases
2 participants