Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify a path #32

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Specify a path #32

merged 2 commits into from
Sep 7, 2018

Conversation

cyril-sf
Copy link
Contributor

@cyril-sf cyril-sf commented Aug 3, 2017 •
edited
Loading

I needed to run this on a specific folder while migrating our codebase.

Let me know if you find that useful.

@rwjblue
Copy link
Member

rwjblue commented Aug 12, 2017

I like it, it starts down the path I was trying to layout in #31.

@cyril-sf - Would you mind double checking that issue to see if we need to make any changes here?

@cyril-sf
Copy link
Contributor Author

cyril-sf commented Aug 30, 2018 •
edited
Loading

I rebased and added a test, just to get this code in a good spot.

I'll take a look at #31 to see what I can do if it's still needed.

@cyril-sf
Copy link
Contributor Author

Failures are unrelated to my code, I'll take a look at it too.

@cyril-sf
Copy link
Contributor Author

cyril-sf commented Aug 31, 2018 •
edited
Loading

error istanbul-lib-instrument@2.3.2: The engine "node" is incompatible with this module. Expected version ">=6".

@rwjblue Do we want to keep the compatibility w/ node 4? Master would fail too if we were to run the tests now. And Node 4 is not officially supported since April 2018 ( https://github.com/nodejs/Release )

This is breaking because of this commit istanbuljs/istanbuljs#198

@cyril-sf
Copy link
Contributor Author

I opened a PR for the node compatibility issue #87

@rwjblue
Copy link
Member

rwjblue commented Aug 31, 2018

I think that #87 should have unblocked the testing issue, right?

@cyril-sf
Specify a path
3b8274a 
By default, `ember-modules-codemode` will modify files in those folders:
"app", "addon", "addon-test-support", "tests", "test-support", "lib"

If you want to run a change in another folder, you can specify a path:

```ember-modules-codemod path_to_use```
@cyril-sf
Add command to debug tests
cf39b59 
Run tests in debug mode (using Chrome's chrome://inspect tab)
`yarn test:debug`
@cyril-sf
Copy link
Contributor Author

That's my goal/hope. I probably won't have time to finish that today, but will make sure to get this through the finish line before next year 😄

@rwjblue rwjblue merged commit 2d64288 into ember-codemods:master Sep 7, 2018
@rwjblue
Copy link
Member

rwjblue commented Sep 7, 2018

Thanks again @cyril-sf!

@rwjblue rwjblue mentioned this pull request Sep 7, 2018
Closed
@cyril-sf cyril-sf deleted the cyril/custom-path branch September 7, 2018 18:26
@cyril-sf
Copy link
Contributor Author

cyril-sf commented Sep 7, 2018

Thanks!

I still need to update the README to document that feature.

@cyril-sf
Copy link
Contributor Author

cyril-sf commented Sep 7, 2018

See #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyril-sf @rwjblue