Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite PathExpression visitor code #62

Merged
merged 1 commit into from
Dec 14, 2019
Merged

Rewrite PathExpression visitor code #62

merged 1 commit into from
Dec 14, 2019

Commits on Dec 14, 2019

  1. Rewrite PathExpression visitor code 

    Instead of having a single visitor for `PathExpression` it is more useful to know if it is the path of a simple mustache, a block, a modifier, etc.

Depending on the parent element we can assume certain things, e.g. inside an `AttrNode` the mustache path can't be a component invocation.

This rewrite also fixes the wrong priority order where properties had priority over components and helpers, which is different in an actual app. If a component/helper with a corresponding name is found than the prefixing will be skipped. This removes the reliance on `getTelemetryFor()` which helps bring us closer to "pods" support.

Due to the different implementation this also removes the `dontAssumeThis` option from the codemod.
    @Turbo87
    Turbo87 committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    0c1885a View commit details
    Browse the repository at this point in the history