Restore the legacy tests #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests were removed in this PR ember-fastboot#805
kiwiupover
changed the title
snewcomer
approved these changes
Jun 8, 2021
| @@ -90,3 +90,34 @@ jobs: | |||
| run: yarn workspace basic-app test:mocha | |||
| - name: Custom App | |||
| run: yarn workspace custom-fastboot-app test:mocha | |||
|
|
|||
| test-legacy-mocha: | |||
| name: Legacy Mocha Tests - ${{ matrix.node-version }} | |||
There was a problem hiding this comment.
I wonder what is legacy about these
There was a problem hiding this comment.
I agree that we probably shouldn't call them legacy 🤔 but I wouldn't think it's a blocker
mansona
force-pushed
the
restore-legacy-tests
branch
from
f07c3ef to
d30117d
Compare
xg-wang
reviewed
Jun 10, 2021
| @@ -46,6 +46,7 @@ | |||
| "body-parser": "^1.18.3", | |||
| "broccoli-asset-rev": "^3.0.0", | |||
| "broccoli-test-helper": "^1.5.0", | |||
| "co": "4.6.0", | |||
There was a problem hiding this comment.
Looks like
co isn't actually being used, we should be able to remove
xg-wang
reviewed
Jun 10, 2021
| # Remove test-packages folder so that we don't leak node_modules between apps | ||
| - name: Remove test-packages | ||
| run: | | ||
| rm -rf test-packages |
There was a problem hiding this comment.
Curious why do we need to remove?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were removed in this PR #805
These tests have not been exercised this the above PR.
https://github.com/ember-fastboot/ember-cli-fastboot/tree/master/packages/ember-cli-fastboot/test
Adding the npm package
[co](https://www.npmjs.com/package/co)which is used when running the legacy tests