Update CI and drop support for Node 12 #902
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix CI for this repo, which has been failing for the last few months, and run against Node 14.x and 16.x.
Updated Node LTS Versions
This drops support for Node 12.x (which is EOL as of 2022/04/30), and runs the tests against 14.x and 16.x.
I also pinned a more recent version of Yarn.
Notes
I had to update
workerpool
in the lockfile to pull in the fix for Node16 mentioned in this issue.Legacy Mocha Tests
These have been failing for a while, with this error:
So I added that to
fastbootDependencies
, which fixed the issue.Notes
Running with Node 16 surfaced a new error with starting the server in the tests, so I removed the
skipNpm: true
option to fix that.Ember-Try Tests
These have also been failing for a while, with this error:
I fixed that by preventing ember-try from running with
--no-lockfile
(which it does by default, and was causing a dependency mismatch when running the tests).